Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash happened in UvRunOnce #9043

Merged
merged 1 commit into from Mar 29, 2017
Merged

Fix crash happened in UvRunOnce #9043

merged 1 commit into from Mar 29, 2017

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Mar 28, 2017

When doing navigation without restarting renderer process, it may happen that the node environment is destroyed but the message loop is still there. In this case we should not run uv loop.

Fix #9004.

Copy link
Contributor

@kevinsawicki kevinsawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zcbenz zcbenz merged commit 9ef1f8c into master Mar 29, 2017
@zcbenz zcbenz deleted the fix-uv-run-crash branch March 29, 2017 04:37
@bpasero
Copy link
Contributor

bpasero commented Mar 29, 2017

Awesome guys ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants